Let a range filter render pre-counted histogram buckets - #132
Open
einari wants to merge 3 commits into
Open
Conversation
The reveal is a clip-path wipe, so the clip has to exist while it animates — clip-path: none is discrete and snaps instead of interpolating. But clip-path clips every descendant, so leaving a zero inset in place after the wipe has landed slices off the hover tooltips of the outermost buttons, which paint outside the panel by design. Widening the settled inset is not a way out: the wipe front IS the inset travelling 100% -> 0, so bleeding it outward extends the travel and the reveal completes early (measured at ~95ms of a 350ms transition with a 32rem bleed). Release the clip once the reveal has landed instead, and put an interpolable inset back before a close begins, so both wipes keep their exact timing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
.toolbar-slot-section was permanently overflow:hidden, which clipped the fan-out and folder panels of any ToolbarGroup that hosts a slot. ToolbarLayout already worked around this with an inline overflow override; move that to a --transitioning modifier class so both hosts share it and the section is only clipped while outgoing content is fading out. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
RangeHistogramFilter could only count values the browser already held, so a range picker over a data set larger than the loaded page misrepresented what each range actually selects - and there was no way to feed it a server-side aggregation. numericRange now takes an optional histogram of pre-counted buckets, rendered as given and scaled against their own tallest bar. The counting itself moves out of the component into buildHistogram so both paths are covered by specs. values stays supported and unchanged for client-side counting. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
numericRange.histogramon a filter definition, and a matchinghistogramprop onRangeHistogramFilter, for rendering buckets that were counted elsewhere — a server aggregating over more rows than are worth sending to the browser, for instancebuildHistogramand theHistogramBuckettype are exported from@cratis/components/FilterChanged
numericRange.valuesis now optional, since a range filter can be driven by pre-counted buckets instead. Supplyingvaluesbehaves exactly as before